@GW_USE_DEVICE_ALLOCATOR_FILE@ #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
HI @pb-cdunn , thanks for submitting this PR. This certainly is a problem that needs to be addressed. We are evaluating your PR and will get back to you soon. |
ahehn-nv
added
bug
|
ok to test |
based on gw_enable_caching_allocator This way, after the library is built and installed, the user does not need to specify `-DGW_ENABLE_CACHING_ALLOCATOR`, which would select the DefaultDeviceAllocator to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
@GW_USE_DEVICE_ALLOCATOR_FILE@based ongw_enable_caching_allocator, to include only one DefaultDeviceAllocator for a given installation.This way, after the library is built and installed, the user does not need to specify
-DGW_ENABLE_CACHING_ALLOCATOR,which would currently select the
DefaultDeviceAllocatorto use.I have not tested this yet. (I think we will need to add the build-directory to the include path.) I wanted to get opinions on this idea first.
To be clear, here is the error that can hit if we fail to use the same compilation flags as when the library was installed: